fix: dispose cy instance and autosave timer on tab close #341
Merged
pradeeban merged 1 commit intoControlCore-Project:devfrom Feb 23, 2026
Merged
fix: dispose cy instance and autosave timer on tab close #341pradeeban merged 1 commit intoControlCore-Project:devfrom
pradeeban merged 1 commit intoControlCore-Project:devfrom
Conversation
Author
|
Hey @pradeeban changes are minimal, no extra lines |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #338
Added dispose() to CoreGraph in 1-core.js which calls cy.destroy(), clears the pending autosave setTimeout, and nulls out cy and dispatcher. Wired it into the useEffect cleanup in GraphArea.jsx and at the top of closeTab() in TabBar.jsx so it fires both on unmount and on explicit tab close.
Without this, every closed tab left a full cytoscape instance (canvas + WebGL context), the Konva stage, edgehandles state, and a live setTimeout all sitting in memory. Open 10 tabs, close them, heap grows forever.