BUG: SUR reader reported wrong height_scale_factor in channel info#268
Merged
BUG: SUR reader reported wrong height_scale_factor in channel info#268
height_scale_factor in channel info#268Conversation
… is now `complex`) - this has been deprecated in numpy 1.20.0
sannant
approved these changes
Dec 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR fixes a bug in SUR reader and prepares for numpy>=1.24.0 compatibility by removing pointers to data type inside numpy (
np.int,np.complexetc.). Note that there is still an issue with Igor and numpy>=1.24.0, see here #266 and wking/igor#4This PR closes #265