-
Notifications
You must be signed in to change notification settings - Fork 370
Migrate repo from VSTest to Microsoft.Testing.Platform #1141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,9 +1,8 @@ | ||||||||||
| <RunSettings> | ||||||||||
| <MSTest> | ||||||||||
| <MaxCpuCount>0</MaxCpuCount> | ||||||||||
| <Parallelize> | ||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we still need this? dotnet/build/Community.Toolkit.Common.targets Lines 19 to 22 in eb25f10
Or can we remove it in this PR if it's redundant now?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Interesting. Only one of these are needed, assuming
|
||||||||||
| <Workers>0</Workers> | ||||||||||
| <Scope>ClassLevel</Scope> | ||||||||||
| </Parallelize> | ||||||||||
| </MSTest> | ||||||||||
| </RunSettings> | ||||||||||
| </RunSettings> | ||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,8 @@ | |
| <PropertyGroup> | ||
| <RepositoryDirectory>$(MSBuildThisFileDirectory)</RepositoryDirectory> | ||
| <BuildToolsDirectory>$(RepositoryDirectory)build\</BuildToolsDirectory> | ||
|
|
||
| <EnableMSTestRunner>true</EnableMSTestRunner> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add a comment to explain what this is and what it does? Or a link to docs if there's any. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Introducing the MSTest Runner - .NET Blog
Run tests with MSTest - Microsoft Learn
It seems to be another option for developers to run tests. According to the blog post, it shouldn't interfere with other methods of running tests. Assuming this is something that we want, we should also set |
||
| </PropertyGroup> | ||
|
|
||
| <Import Project="$(BuildToolsDirectory)Community.Toolkit.Common.props" /> | ||
|
|
@@ -44,4 +46,4 @@ | |
| </When> | ||
| </Choose> | ||
|
|
||
| </Project> | ||
| </Project> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,10 @@ | ||
| { | ||
| "sdk": { | ||
| "version": "10.0.101", | ||
| "version": "10.0.103", | ||
| "rollForward": "latestFeature", | ||
| "allowPrerelease": false | ||
| }, | ||
| "test": { | ||
| "runner": "Microsoft.Testing.Platform" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this because the verbosity is now detailed by default, or something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole UX for MTP is different, and there is no
-l(logger). I'm not sure what piece of info was originally intended to be looked at with detailed verbosity, maybe @nohwnd might know what VSTest exactly does under each verbosity, but anyways, I guess if there is something you don't like with the new output, we would love to know to add more customizations and/or having better defaults.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If detailed shows passed tests, then
--output detailedwould be kinda the equivalent here.