fix(client): close active NUI elements before opening new ones#93
Open
YgorLeal wants to merge 1 commit intoCommunityOx:mainfrom
Open
fix(client): close active NUI elements before opening new ones#93YgorLeal wants to merge 1 commit intoCommunityOx:mainfrom
YgorLeal wants to merge 1 commit intoCommunityOx:mainfrom
Conversation
Prevents NUI focus bugs when multiple ox_lib UI elements overlap. The keepInput variable in main.lua is a single scalar that gets overwritten when a second UI opens, causing broken focus state when either UI closes. Adds lib.closeAllNui(except) which cleanly closes all other open NUI elements before a new one opens, ensuring keepInput always captures the true pre-NUI state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inputDialogwhile a context menu is open)keepInputinmain.luais a single variable that gets overwritten when a second UI opens, losing the original pre-NUI statelib.closeAllNui(except)that cleanly closes all other open NUI elements before a new one opensChanges
lib.closeAllNui(except)— closes context, menu, input, alert, and radial (with guards to avoid unnecessaryresetNuiFocuscalls)lib.showContext()callslib.closeAllNui('context')before openinglib.inputDialog()callslib.closeAllNui('input')before openinglib.alertDialog()callslib.closeAllNui('alert')before openinglib.showMenu()callslib.closeAllNui('menu')before openingThe
exceptparameter ensures a UI type doesn't close itself (e.g., navigating between context sub-menus still works normally).Test plan
inputDialogvia script — context should close, input should open cleanlyexcept='context')nil), alert should open