稀にユーザ情報が取得できない場合があり取得出来ないとコメントすら表示されなくなるので回避#195
Open
azutake wants to merge 2 commits intoCommentViewerCollection:masterfrom
Open
稀にユーザ情報が取得できない場合があり取得出来ないとコメントすら表示されなくなるので回避#195azutake wants to merge 2 commits intoCommentViewerCollection:masterfrom
azutake wants to merge 2 commits intoCommentViewerCollection:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
稀にユーザ情報が取得出来ない時があり（サーバ側が不安定だったり、人により）、その場合コメントすら表示されなくなってしまう。
解決方法
ユーザ情報取得時にDataが0だった場合に例外としていたのをnullにし、nullじゃなければニックネームを使用するようにした
影響
無し。使用箇所はTestCommentProviderのみ。