Conversation
Member
mart-r
changed the title
…ing-against-current-state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out the patching system introduced in #27 was merged in some kind of debug state where it didn't actually do what it was supposed to.
That meant that the tutorials were never actually being tested against the current state of the core lib.
So this PR fixes that.
PS:
After this is done, I want to do a follow-up PR for #333 and #343 such that the script there uses the script here to bump the install targets in notebooks as well.
NOTE: Should be good to go after #349 is merged into this one