Skip to content

Comments

fix: close completeness gaps from review-implementation audit (#88)#89

Merged
GiggleLiu merged 6 commits intomainfrom
fix/issue-88-completeness-gaps
Feb 20, 2026
Merged

fix: close completeness gaps from review-implementation audit (#88)#89
GiggleLiu merged 6 commits intomainfrom
fix/issue-88-completeness-gaps

Conversation

@GiggleLiu
Copy link
Contributor

Summary

  • Fix MaximalIS CLI dispatch: Add missing MaximalIS match arms to load_problem() and serialize_any_problem()
  • Fix models/mod.rs re-exports: Add missing re-exports for MaximumClique, ILP, KSatisfiability
  • Rename 21 test functions: Standardize to test_<source>_to_<target>_closed_loop naming convention
  • Add 3 example programs: SAT→CircuitSAT, MaximumSetPacking→MaximumIndependentSet, KSatisfiability→Satisfiability
  • Add paper entries: Problem definitions for MaximalIS, BMF, PaintShop, BicliqueCover; reduction rule for SAT→CircuitSAT

Closes #88

Test plan

  • make test — all 1506 unit + 96 integration + 43 doc tests pass
  • make clippy — clean
  • New example tests: test_satisfiability_to_circuitsat, test_maximumsetpacking_to_maximumindependentset, test_ksatisfiability_to_satisfiability
  • All 21 renamed tests pass under new names
  • cargo run --example export_graph — reduction graph unchanged
  • make export-schemas — 21 problem schemas exported

🤖 Generated with Claude Code

GiggleLiu and others added 5 commits February 20, 2026 11:14
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…and SAT to CircuitSAT rule

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Feb 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.36%. Comparing base (7070fa6) to head (d4d1fe1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files         197      197           
  Lines       27210    27210           
=======================================
  Hits        26222    26222           
  Misses        988      988           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses completeness gaps identified in issue #88 by fixing CLI dispatch for MaximalIS, adding missing re-exports, standardizing test naming, adding example programs, and documenting problem definitions and reduction rules in the paper.

Changes:

  • Fixed MaximalIS CLI dispatch by adding it to load_problem() and serialize_any_problem() functions
  • Added missing re-exports for MaximumClique, ILP, and KSatisfiability to models/mod.rs
  • Renamed 21 test functions to follow the standardized test_<source>_to_<target>_closed_loop naming convention
  • Added 3 new example programs for SAT→CircuitSAT, MaximumSetPacking→MaximumIndependentSet, and KSatisfiability→Satisfiability reductions
  • Added problem definitions and display names for MaximalIS, BMF, PaintShop, and BicliqueCover
  • Added reduction rule documentation for SAT→CircuitSAT

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/suites/examples.rs Added test registrations for three new example programs
src/unit_tests/rules/*.rs (21 files) Renamed test functions to follow test_<source>_to_<target>_closed_loop convention
src/models/mod.rs Added missing re-exports for MaximumClique, ILP, and KSatisfiability
problemreductions-cli/src/dispatch.rs Added MaximalIS match arms to load_problem and serialize_any_problem
examples/reduction_satisfiability_to_circuitsat.rs New example demonstrating SAT to CircuitSAT reduction
examples/reduction_maximumsetpacking_to_maximumindependentset.rs New example demonstrating MaximumSetPacking to MaximumIndependentSet reduction
examples/reduction_ksatisfiability_to_satisfiability.rs New example demonstrating KSatisfiability to Satisfiability reduction
docs/paper/reductions.typ Added display names, problem definitions for 4 problems, and SAT→CircuitSAT reduction rule

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

The previous example used only size-2 sets, which is degenerate
(equivalent to a matching problem). Replace with 5 sets of sizes
2 and 3 over an 8-element universe for a more general demonstration.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@GiggleLiu GiggleLiu merged commit 7207490 into main Feb 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit: Completeness gaps in models and rules

1 participant