Custom scopes for different requirements (Android)#267
Closed
AlvinTCH wants to merge 1 commit intoCodetrixStudio:masterfrom
Closed
Custom scopes for different requirements (Android)#267AlvinTCH wants to merge 1 commit intoCodetrixStudio:masterfrom
AlvinTCH wants to merge 1 commit intoCodetrixStudio:masterfrom
Conversation
…itialize function for users to add scopes on the fly
Collaborator
|
this is not part of #167 ? |
Contributor
Author
|
Am not too sure if it's the same as #167 regarding the requirements. But it should solve the same issues i guess? I need to get familiar with swift (which I am not ATM). so just in case the outcome is not that desirable, I was thinking of putting it up as a separate pull request in the next few days when I come up with the solution and test it inside my app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having custom scopes whenever the function initializes
I have an app whereby there are different scope requirements for different functions of the app so as to not request for excessive scopes from the user.
For example,
['email', 'profile']is sufficient.['email', 'profile', 'https://www.googleapis.com/auth/calendar']There is currently no convenient way to do this in the app as it takes the scope from the capacitor config (i.e capacitor.config.json)
So in this implementation, I am taking the data from the
GoogleAuth.initializefunction as it's used on the web and accessing the data inside Android for reusabilityIn JS, initialize GoogleAuth same as web
In GoogleAuth.java, I moved the entire load function to another function. So it becomes as follows
Then I call the
loadSignInClientfrominitialize, while getting the custom data from the plugin call, with the data inside capacitor.json as a fallbackNote