Sheffield | 25-SDC-Nov | Sheida Shabankari | Sprint 1 |Hashtag link doesn't work correctly #106
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheida-shab
added
Needs Review
illicitonion
reviewed
Feb 4, 2026
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
The last commit looks good here, but there's lots of unrelated changes in here too? Please remove them
illicitonion
added
Reviewed
sheida-shab
force-pushed
the
Feat-fixBug-Hashtaglink
branch
from
7e10442 to
afec6ed
Compare
Author
|
Thanks for your feedback.I removed extra commits. |
sheida-shab
added
Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
Briefly explain your PR.
Issue:
When loading populated data, some hashtag links in certain blooms (e.g., "Let's get some #SwizBiz love!!") led to empty pages instead of showing the related blooms. Other blooms with the same hashtag worked correctly.
Cause:
The hashtag parsing function was not correctly handling certain hashtag positions or multiple hashtags, resulting in malformed links.
Solution:
Updated the _formatHashtags() function to correctly parse hashtags containing letters, numbers, and underscores. This ensures that clicking a hashtag now navigates to the correct page showing all blooms containing that hashtag, including the one clicked.