Sheffield | 25-SDC-Nov | Sheida Shabankari | Sprint 1 |Extra long blooms#105
Sheffield | 25-SDC-Nov | Sheida Shabankari | Sprint 1 |Extra long blooms#105sheida-shab wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
sheida-shab
added
Needs Review
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
This looks good, but it looks like you have fixes for other problems in this same PR - please only include one fix per PR
backend/endpoints.py
Outdated
| if len(content)>280 : | ||
| return jsonify({"success": False, "error": "Bloom must be 280 characters or less"}), 400 |
There was a problem hiding this comment.
If we wanted to change the limit to 300 in the future, we'd need to edit multiple values in this file. How could we avoid this?
There was a problem hiding this comment.
If we wanted to change the limit to 300 in the future, we'd need to edit multiple values in this file. How could we avoid this?
front-end/lib/api.mjs
Outdated
| if (content.length>280){ | ||
| handleErrorDialog(new Error("Bloom must be 280 characters or less")); |
There was a problem hiding this comment.
If we wanted to change the limit to 300 in the future, we'd need to edit multiple values in this file. How could we avoid this?
There was a problem hiding this comment.
If we wanted to change the limit to 300 in the future, we'd need to edit multiple values in this file. How could we avoid this?
There was a problem hiding this comment.
Fixed the extra commits issue as well.
illicitonion
added
Reviewed
sheida-shab
force-pushed
the
Feat-fixBug-longBlooms
branch
from
1f658ba to
33e13ae
Compare
sheida-shab
added
Needs Review
2 participants
PR description :
Fix Bloom length validation (max 280 chars)