London | SDC-Nov-25 | Ikenna Agulobi | Sprint 3 | Middleware

[ike-agu]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

• Complete middleware exercise

[ike-agu]

Please could you help edit my PR title with the right meta data. It doesn’t allow me. I missed one pipe (|) between sprint 3 and middleware.

[OracPrime]

A comment to understand, nothing to change. Excellent submission

[OracPrime]

Nice! Many trainees haven't bothered with this file, but adding a readme like this is an excellent habit to get into.

[OracPrime]

This is a really strong submission, and I'm only raising this tiny technical point because there was nothing else wrong with the code. utf8 characters and be up to 4 bytes long. They're normally 1, but they can be 4. If that 4 byte sequence was split across two chunks, the toString would be incorrect. More robust would be something like

let chunks = [];

req.on("data", (chunk) => {
  chunks.push(chunk);
});

req.on("end", () => {
  const raw = Buffer.concat(chunks).toString("utf8");
  // ... rest of the logic
});

But that's really quite subtle - don't worry about changing it.