generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 243
London | JAN-ITP-26 | Kayanat Suleman | Sprint 3 | Alarm Clock App #969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KayanatSuleman
wants to merge
6
commits into
CodeYourFuture:main
Choose a base branch
from
KayanatSuleman:feature/alarm-clock
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+48
−2
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ddb79fc
Updating index.html - with an accurate title
KayanatSuleman 61fe419
Alarm clock: display entered time in mm:ss format
KayanatSuleman 7cafbef
Alarm clock: start timer with setInterval every 1000ms
KayanatSuleman 6b24f06
Alarm clock: decrement and update heading each second
KayanatSuleman eb90347
Alarm clock: play alarm and stop timer at 00:00
KayanatSuleman 5d17875
Updating the app as per the review comments
KayanatSuleman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,50 @@ | ||
| function setAlarm() {} | ||
| let intervalId = null; | ||
|
|
||
| function formatTime(totalSeconds) { | ||
| const minutes = Math.floor(totalSeconds / 60); | ||
| const seconds = totalSeconds % 60; | ||
|
|
||
| const formattedMinutes = String(minutes).padStart(2, "0"); | ||
| const formattedSeconds = String(seconds).padStart(2, "0"); | ||
|
|
||
| return `${formattedMinutes}:${formattedSeconds}`; | ||
| } | ||
|
|
||
| function setAlarm() { | ||
| const input = document.getElementById("alarmSet"); | ||
| const heading = document.getElementById("timeRemaining"); | ||
|
|
||
| let value = input.value | ||
|
|
||
| if (value === "") { | ||
| return; | ||
| } | ||
|
|
||
| let remainingSeconds = Number(value); | ||
|
|
||
| if (remainingSeconds <= 0 || isNaN(remainingSeconds)) { | ||
| return; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also instead of |
||
| } | ||
|
|
||
| heading.innerText = `Time Remaining: ${formatTime(remainingSeconds)}`; | ||
|
|
||
| if (intervalId !== null) { | ||
| clearInterval(intervalId); | ||
| } | ||
|
|
||
| intervalId = setInterval(() => { | ||
| remainingSeconds -= 1; | ||
|
|
||
| if (remainingSeconds <= 0) { | ||
| heading.innerText = `Time Remaining: ${formatTime(0)}`; | ||
| playAlarm(); | ||
| clearInterval(intervalId); | ||
| intervalId = null; | ||
| return; | ||
| } | ||
| heading.innerText = `Time Remaining: ${formatTime(remainingSeconds)}`; | ||
| }, 1000); | ||
| } | ||
|
|
||
| // DO NOT EDIT BELOW HERE | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of
returningit will be better to show the user an appropriate message, can you think of a way to do that please.