Api security #255
Open
Api security #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror messages to EditScreener and SaveFormSchema endpoints
Justin-MacIntosh
requested changes
Feb 12, 2026
Collaborator
Justin-MacIntosh
left a comment
Justin-MacIntosh
left a comment
There was a problem hiding this comment.
Very small changes requested. Thank you for introducing all of these validation concepts!!
|
|
||
| public class JsonServerExceptionMappers { | ||
|
|
||
| // @ServerExceptionMapper |
Collaborator
There was a problem hiding this comment.
remove commented code
| private static final Logger LOG = Logger.getLogger(ValidationExceptionMapper.class); | ||
|
|
||
| @Override | ||
| public Response toResponse(ConstraintViolationException e) { |
Collaborator
There was a problem hiding this comment.
nit: feel free to ignore this change, but I would avoid 1letter variable names likeeorv. In this case I would go with something like excandviolation`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #250 by adding validation/serialization to the relevant endpoints. Invalid requests return a standardized
ApiErrorwith a message. For the case where someone creates a Screener while supplying apublishedScreenerIdfield, the API responds with:ApiErrorcan be used elsewhere to return a response instead of throwing.