Conversation
- Use 'ask' instead of 'offer' action type - Add state description with order book interface - Document simultaneous tick trading model - Support both 4 and 5 player games
There was a problem hiding this comment.
Pull request overview
This PR adds support for Figgie, Jane Street's open-outcry trading card game, as a new arena in the CodeClash platform. Figgie simulates commodities trading where 4-5 players buy and sell cards to accumulate a secret goal suit.
Key Changes
- New Figgie arena implementation following established patterns from Gomoku and Bridge arenas
- Complete test suite with 6 unit tests covering validation and player count requirements
- Configuration file and Docker setup for the game environment
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
codeclash/arenas/figgie/figgie.py |
Main Figgie arena implementation with validation, game execution, and results parsing |
codeclash/arenas/figgie/Figgie.Dockerfile |
Docker configuration to set up Python 3.10 and clone the Figgie game repository |
codeclash/arenas/__init__.py |
Registers FiggieArena in the arena module exports |
tests/arenas/test_figgie.py |
Unit tests for Figgie validation logic and player count requirements |
configs/test/figgie.yaml |
Test configuration with game rules and state documentation for 4 players |
codeclash/arenas/bridge/bridge.py |
Code cleanup: removed unused import, consistent formatting, quote standardization |
codeclash/arenas/gomoku/gomoku.py |
Formatting improvements for consistency (line wrapping, trailing commas) |
tests/arenas/test_bridge.py |
Minor formatting cleanup (removed blank line, consistent line wrapping) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Great job with Figgie @Muhtasham! Implementation looks very good, I just made a minor tweak of adding a Thanks as well for going through the effort of writing a Figgie implementation from the ground up! It does look like there's not really a great open-source implementation. |
Summary
Changes
codeclash/arenas/figgie/- Arena implementationconfigs/test/figgie.yaml- Test configtests/arenas/test_figgie.py- Unit tests (6 tests)Game Overview
Figgie simulates commodities trading where players buy/sell cards to accumulate the goal suit. The goal suit is secret until game end.
Test plan