Fix missing new keyword in error constructors and redundant true && in logic#10
Open
YonganZhang wants to merge 1 commit intoChinaSiro:mainfrom
Open
Conversation
…`true &&` in logic check - src/commands.ts: `throw ReferenceError()` → `throw new ReferenceError()` - src/utils/claudeInChrome/setup.ts: `throw Error()` → `throw new Error()` - src/commands/chrome/chrome.tsx: Remove redundant `true &&` in `isDisabled` check Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
restored-src/src/commands.ts:707:throw ReferenceError()→throw new ReferenceError()— missingnewkeywordrestored-src/src/utils/claudeInChrome/setup.ts:196:throw Error()→throw new Error()— same issuerestored-src/src/commands/chrome/chrome.tsx:189: Remove redundanttrue &&inisWSL || true && !isClaudeAISubscriber— due to operator precedence, the expression always evaluates to true for non-subscribers🤖 Generated with Claude Code