Modify contains comparison to ignore missing keys recursively#6
Open
erussell wants to merge 3 commits intoChannelIQ:masterfrom
Open
Modify contains comparison to ignore missing keys recursively#6erussell wants to merge 3 commits intoChannelIQ:masterfrom
erussell wants to merge 3 commits intoChannelIQ:masterfrom
Conversation
|
I didn't realize this was not the default behavior - would be great to have this integrated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I modified the contains function to ignore missing keys at all levels of the object tree, instead of just the top level. I added tests for all of the odd scenarios I could think of.