Use NodeSource LTS repositories for reliable Node.js 20+ bootstrap on Linux#28
Merged
ChangeHow merged 4 commits intofeat/sync-local-zsh-configfrom Mar 22, 2026
Merged
Conversation
Co-authored-by: ChangeHow <23733347+ChangeHow@users.noreply.github.com> Agent-Logs-Url: https://github.com/ChangeHow/suitup/sessions/96c63f7e-7f36-4db4-a11a-5c2983e445da
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on quick init support for fresh machines
Use NodeSource repositories for reliable Node.js 18+ bootstrap on Linux
Mar 22, 2026
Owner
|
不是,哥们,别用 node18,至少要求 node20 @copilot |
Co-authored-by: ChangeHow <23733347+ChangeHow@users.noreply.github.com> Agent-Logs-Url: https://github.com/ChangeHow/suitup/sessions/4dc0df07-50ce-4a7c-8cc7-9f713eba218d
Contributor
Author
ChangeHow
reviewed
Mar 22, 2026
install.sh
Outdated
| apt-get) | ||
| install_with_manager "${manager}" nodejs npm | ||
| log "Adding NodeSource repository for Node.js 18..." | ||
| if ! curl -fsSL https://deb.nodesource.com/setup_18.x | sudo -E bash -; then |
Copilot
AI
changed the title
Use NodeSource repositories for reliable Node.js 18+ bootstrap on Linux
Use NodeSource repositories for reliable Node.js 20+ bootstrap on Linux
Mar 22, 2026
Co-authored-by: ChangeHow <23733347+ChangeHow@users.noreply.github.com> Agent-Logs-Url: https://github.com/ChangeHow/suitup/sessions/a731a56d-aa64-4248-94c0-8ac77ae3f058
Copilot
AI
changed the title
Use NodeSource repositories for reliable Node.js 20+ bootstrap on Linux
Use NodeSource LTS repositories for reliable Node.js 20+ bootstrap on Linux
Mar 22, 2026
ChangeHow
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing Node.js via default
apt-get/dnf/yumpackages often yields outdated versions that fail the>= 20version gate, breaking fresh-machine installs. The existing skip-if-present logic was already correct; only the installation path needed fixing.Changes
install.sh—ensure_node_runtime: Forapt-getanddnf/yum, run the official NodeSource LTS setup script before installingnodejs, replacing the bare distro-package install:Using
setup_lts.xensures the latest LTS release is always installed rather than pinning to a specific major version. The minimum required version remains Node.js 20. Both Linux branches include explicit error handling on the setup script so failures surface with a clear message rather than a confusing downstream install error. Installation is skipped entirely whennodeandnpmare already present at a compatible version (>= 20).tests/install-script.test.js: Two new tests — one asserting the skip-if-node >= 20-present guard, one asserting the NodeSource LTS URLs (setup_lts.x) and| sudo -E bash -pattern are present for both Debian and RPM targets.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.