Conversation
Fixes #25 — the append mode now sources ~/.config/zsh/shared/tools.zsh (which has the correct fzf-before-atuin order and caching) instead of generating inline eval commands with the wrong order that broke atuin's Ctrl-R binding. Co-authored-by: ChangeHow <23733347+ChangeHow@users.noreply.github.com> Agent-Logs-Url: https://github.com/ChangeHow/suitup/sessions/c4e1ed01-6e6f-4627-8e2a-6713a92a1d55
Copilot
AI
changed the title
[WIP] Fix append logic in suitup initialization
fix: tools-init append reuses managed tools.zsh instead of inline evals
Mar 21, 2026
Owner
|
@copilot 其他的 append 都没有问题了吗?检查过了吗? |
…lining zsh-options, env-vars, perf, and fzf-config blocks now copy config files to ~/.config/zsh/ and source them, consistent with tools-init. Prevents duplication if user later runs setup. Co-authored-by: ChangeHow <23733347+ChangeHow@users.noreply.github.com> Agent-Logs-Url: https://github.com/ChangeHow/suitup/sessions/a9f7a54f-f6ca-4022-89ec-c7daa9cd773b
Contributor
Author
已全面检查并修复。除了
所有 block 现在统一使用 |
Copilot
AI
changed the title
fix: tools-init append reuses managed tools.zsh instead of inline evals
fix: all append blocks reuse managed config files instead of inlining
Mar 21, 2026
Owner
|
/close #25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The append mode blocks inlined config file content directly into
.zshrcinstead of reusing suitup's managed config files under~/.config/zsh/. This caused duplicate loading if users later ransetup, and specifically fortools-init, the wrong fzf/atuin order broke atuin'sCtrl-Rbinding.Changes
src/append.js: All append blocks now consistently copy config files to~/.config/zsh/viacopyIfNotExistsand source them withsource_if_exists, instead of inlining content. Affected blocks:tools-init: replaced inlineevalcommands with sourcingshared/tools.zsh(fixes fzf/atuin order and adds caching)zsh-options: replaced inlinedoptions.zshcontent with copy+source ofcore/options.zshenv-vars: replaced inlinedenv.zshcontent with copy+source ofcore/env.zshperf: replaced inlinedperf.zshcontent with copy+source ofcore/perf.zshfzf-config: replaced inlinedfzf.zshcontent with copy+source ofshared/fzf.zshtests/append.test.js: Updated test fixtures to match new source-based format; added tests verifying no content is inlined for each fixed block.Before (example —
tools-init):After (all blocks follow this pattern):
tools.zshalready loads fzf before atuin (so atuin keepsCtrl-R) and uses_source_cached_tool_initfor faster startup. All other blocks similarly source their respective managed files, preventing duplication if the user later migrates to fullsetupmode.📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.