Open
Conversation
nd-certora
approved these changes
Jul 4, 2023
Contributor
nd-certora
left a comment
nd-certora
left a comment
There was a problem hiding this comment.
looks good, a few fixes, I can take another look after
| ], | ||
| "verify": "ERC20:certora/spec/general.spec", | ||
| "solc": "solc8.17", | ||
| "solc_args": [], |
Contributor
There was a problem hiding this comment.
remove solc and solc_args
| ], | ||
| "verify": "Vault:certora/spec/general.spec", | ||
| "solc": "solc8.17", | ||
| "solc_args": [], |
Contributor
There was a problem hiding this comment.
remove solc and solc_args
| @@ -0,0 +1,122 @@ | |||
| using DummyERC20A as erc20; | |||
|
|
|||
Contributor
There was a problem hiding this comment.
comment:
/** General spec file that can used on any solidity contract, helps highlight the behavior or the contract **/
| @@ -0,0 +1,9 @@ | |||
| { | |||
| "files": [ | |||
| "contracts/Vault.sol:Vault" | |||
|
|
||
| rule decreaseInERC20(method f) { | ||
|
|
||
| uint256 before = erc20.balanceOf(currentContract); |
Contributor
There was a problem hiding this comment.
ERC20Helper and then this support multiple erc20 , did this compile without using erc20?
nd-certora
approved these changes
Aug 2, 2023
| "certora/helpersContracts/ERC20helper.sol:ERC20Helper" | ||
| ], | ||
| "verify": "ERC20:certora/spec/general.spec", | ||
| "solc": "solc8.17", |
Contributor
There was a problem hiding this comment.
remove solce, type in general
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.