Skip to content

[ENG-9857] Refactor notification type references to use NotificationTypeEnum#11520

Merged
cslzchen merged 6 commits intoCenterForOpenScience:feature/notifications-refactor-post-releasefrom
Ostap-Zherebetskyi:fix/consolidate_notification_type_enum
Feb 13, 2026
Merged

[ENG-9857] Refactor notification type references to use NotificationTypeEnum#11520
cslzchen merged 6 commits intoCenterForOpenScience:feature/notifications-refactor-post-releasefrom
Ostap-Zherebetskyi:fix/consolidate_notification_type_enum

Conversation

@Ostap-Zherebetskyi
Copy link
Collaborator

Purpose

Refactor notification type references to use NotificationTypeEnum

  • Updated all instances of NotificationType.Type to NotificationTypeEnum in test files and application code.
  • Ensured consistency in notification type usage.
  • This change improves clarity and maintainability by standardizing the notification type references.

Changes

See diff

QA Notes

N/A

Documentation

N/A

Side Effects

N/A

Ticket

https://openscience.atlassian.net/browse/ENG-9857

@Ostap-Zherebetskyi Ostap-Zherebetskyi marked this pull request as ready for review January 2, 2026 15:18
@Ostap-Zherebetskyi Ostap-Zherebetskyi force-pushed the fix/consolidate_notification_type_enum branch from c313970 to bc5afe6 Compare February 3, 2026 10:39
@Ostap-Zherebetskyi Ostap-Zherebetskyi force-pushed the fix/consolidate_notification_type_enum branch from 95f0d0e to c969bdf Compare February 12, 2026 15:28
- Updated all instances of NotificationType.Type to NotificationTypeEnum in test files and application code.
- Ensured consistency in notification type usage across various tests including auth, claims, events, and more.
- This change improves clarity and maintainability by standardizing the notification type references.
@Ostap-Zherebetskyi Ostap-Zherebetskyi force-pushed the fix/consolidate_notification_type_enum branch from c969bdf to e4079a0 Compare February 12, 2026 15:44
Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ⭐

@cslzchen cslzchen merged commit 1c089a2 into CenterForOpenScience:feature/notifications-refactor-post-release Feb 13, 2026
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants