[SVCS-528] Let WB know a request is coming from MFR#292
Closed
AddisonSchiller wants to merge 1 commit intoCenterForOpenScience:developfrom
Closed
[SVCS-528] Let WB know a request is coming from MFR#292AddisonSchiller wants to merge 1 commit intoCenterForOpenScience:developfrom
AddisonSchiller wants to merge 1 commit intoCenterForOpenScience:developfrom
Conversation
cslzchen
changed the title
cslzchen
approved these changes
Oct 30, 2017
| try: | ||
| self.url = self.request.query_arguments['url'][0].decode('utf-8') | ||
| # TODO should probably use furl here, but maybe wait till after furl is upgraded | ||
| self.url += '&mfr=true' |
Contributor
There was a problem hiding this comment.
This is fine since self.url is a literal string instead of an object as long as the URL does not contain fragment parameters.
This was referenced Dec 5, 2017
Contributor
|
Replaces by #303. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ticket MUST be merged after its Waterbutler counterpart
Ticket
https://openscience.atlassian.net/browse/SVCS-528
Related Waterbutler counterpart PR: CenterForOpenScience/waterbutler#290
Purpose
Changes
Append a
mfrquery param to WB urls to let it know the request is coming from WBMove .gdoc extension from unoconv renderer/exporter to pdf renderer
Side effects
As long as the
mfrquery param is in effect, noneQA Notes
This must be tested with its WB counterpart to have any effect.
Deployment Notes