Draft
Conversation
added 2 commits
March 13, 2026 13:08
for slicecam acquisition mode. no code changes yet.
calculate_centroid() and calculate_acquisition_offsets()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses issue #334.
This also replaces the stagnant PR #363, but it picks up exactly where #363 left off. Since the time 363 was started, main has progressed significantly so this is a new branch off the current main branch as it sits today, then
git cherry-pickec3cce4git cherry-pick363df0dto bring in the changes that were started back in November.
The first commit only splits non-Interface code out of
slicecam_interface.cppin preparation for development, to make a clear separation of functionality and improve readability. No functional code changes yet.The second commit adds
acquire_target()function, and placeholders forcalculate_centroid()andcalculate_acquisition_offsets().Starting this PR but in draft mode, just to bring visibility to the feature.