add solution to spec explicitly#199
Open
MilyMilo wants to merge 1 commit intoCTFd:solutions-writeupfrom
Open
Conversation
ColdHeat
requested changes
Feb 12, 2026
Member
ColdHeat
left a comment
ColdHeat
left a comment
There was a problem hiding this comment.
The code as well should prioritize state as the main field and visibility as an alias
Comment on lines
+56
to
+58
| # path: writeup/WRITEUP.md | ||
| # visibility: solved # hidden | visible | solved | ||
| solution: writeup/WRITEUP.md |
Member
There was a problem hiding this comment.
We should prioritize state over visibility. The name is a bit incorrect but state is also used for challenges. We have to reasonably map to the models imo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #198 by adding solution to the challenge spec.
Solution can either be a string (path to the file), or an object specifying path, as well as visibility (or state, both work - ctfd uses state, but i feel visibility is more user friendly). It will upload images as before, and render snippets. HTML style image includes are ignored on purpose - but that can be changed.
Also correctly syncs the solutions with a patch instead of a post.