-
Notifications
You must be signed in to change notification settings - Fork 0
Refactore #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Omaima33
wants to merge
57
commits into
develop
Choose a base branch
from
refactore
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactore #2
Changes from all commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
ee35f66
polish component states with hover, focus, and disabled styles
Omaima33 92d5393
add useForm hook and FormContext for form state management
Omaima33 0f17c77
add Form wrapper component with submit handling
Omaima33 7118c2c
export Form, useForm, and FormContext from package
Omaima33 cd3d0b4
increase timeout for autoDismiss test stability
Omaima33 e946f54
add PasswordInput component with visibility toggle and strength meter
Omaima33 7f1c2e8
add NumberInput component with increment buttons and formatting
Omaima33 a8b6ed9
add DatePicker component with calendar popup
Omaima33 f815264
add PhoneInput component with country code selection
Omaima33 f4524f1
feat: add FileInput component with drag-and-drop and preview
Omaima33 f59e2e6
feat: add ColorPicker component with swatches and RGB/HSL inputs
Omaima33 b565391
feat: add Switch component with toggle states and customization
Omaima33 86a2a05
Merge branch 'develop' of https://github.com/CISCODE-MA/FormKit-UI in…
Omaima33 5568524
refactor: restrict public API to DynamicForm export only
Omaima33 1d0f857
refactor: restructure codebase to CHM architecture with core/, models…
Omaima33 89d769b
chore: remove legacy code and consolidate to CHM architecture
Omaima33 a917861
feat(testing): add test suite achieving 80%+ coverage (192 tests)
Omaima33 f55c79b
docs: enhance JSDoc for FieldType and ConditionalOperator, add changeset
Omaima33 b50ff0e
refactor: fix layer import rules and component default exports
Omaima33 4ac5a4a
style: add field components with improved styling
Omaima33 c39dcd9
Merge branch 'feat/instructions-refactor' of https://github.com/CISCO…
Omaima33 e3c28a5
restore the checkbox field
Omaima33 73945c6
restore the password field
Omaima33 cb22946
feat: add PhoneField with country selector and countries.json data (2…
Omaima33 6178e0e
password field style adjustments
Omaima33 af3350d
feat(FileField): add accept, maxFileSize, and multiple config options…
Omaima33 3ce0f1d
adjust radio and checkbox fields styles
Omaima33 650d99b
adjust szitch field styles
Omaima33 8df9c5e
feat: add SliderField with range input, editable value sync, and min/…
Omaima33 5cf1c49
feat: add RangeSliderField with dual-thumb slider and editable from/t…
Omaima33 a714f34
feat: add OTPField with configurable length and Full paste support
Omaima33 76cad4c
feat: add TagsField with multi-tag input, paste support, and configur…
Omaima33 596f15c
feat: add RatingField with star rating, half-star support, and keyboa…
Omaima33 9e8d4e8
feat: add TimeField with step interval
Omaima33 1f4e2ba
feat: add DateTimeField with combined date and time input
Omaima33 c127a06
test: add comprehensive tests for new field components
Omaima33 445e57e
fix: unify checkbox styles across components
Omaima33 c842e31
feat: add MultiSelectField with search, tags, and keyboard navigation
Omaima33 30d8cb3
fix: remove focus styles from rating field
Omaima33 af05926
feat: update SelectField to use custom dropdown with search matching …
Omaima33 713f335
fix: update field and form tests
Omaima33 9e132c0
feat: update time, date and dateTime fields styles to have custom dro…
Omaima33 6dbbf5b
fix: adjust select and multi select fields styles
Omaima33 61a893a
fix: update dropdowns and pickers positioning and style across compon…
Omaima33 3476dae
feat: add responsive measures to form fields
Omaima33 c573c51
feat: update OTP field styles to support mobile layout
Omaima33 bb0d904
feat(i18n): add internationalization with English and French locale s…
Omaima33 94edf86
feat(form): automatically scroll to first invalid field and focus it …
Omaima33 60a4fff
feat(ArrayField): refactor to reuse Field components via scoped context
Omaima33 3db31b7
feat: add translation content for Array field and optional params
Omaima33 c5edb9c
refactor: remove unused config param
Omaima33 e0011bb
feat(layout): add grid-based layout system with sections and responsi…
Omaima33 c5d428a
fix(ArrayField): enable per-field Zod validation and error display fo…
Omaima33 6ae676e
refactore and remove duplicate logic
Omaima33 9b46dde
Merge branch 'develop' into refactore
Omaima33 b855342
address and fix the Sonar annotated findings
Omaima33 bd5f48c
Merge branch 'refactore' of https://github.com/CISCODE-MA/FormKit-UI …
Omaima33 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| --- | ||
| '@ciscode/ui-form-kit': patch | ||
| --- | ||
|
|
||
| Improved field component styles with transitions, hover states, and success states | ||
|
|
||
| - Added transition-all duration-150 for smooth animations | ||
| - Added hover:border-gray-400 for hover states on inputs | ||
| - Added green success state (border-green-500) when field is valid | ||
| - Improved responsive padding (px-3 py-2 sm:px-4 sm:py-2.5) | ||
| - Better disabled states with hover:border-gray-300 | ||
| - Improved checkbox, radio, and switch sizing | ||
| - Better file input button styling with blue background | ||
| - Added aria-live=polite to error messages | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| --- | ||
| '@ciscode/ui-form-kit': minor | ||
| --- | ||
|
|
||
| Refactor codebase to align with copilot-instructions.md guidelines | ||
|
|
||
| **Architecture Changes:** | ||
|
|
||
| - Restructured to Component-Hook-Model (CHM) architecture | ||
| - Created `src/core/` for framework-free pure functions (validator, conditional, schema-helpers) | ||
| - Created `src/models/` for TypeScript contracts with zero runtime logic | ||
| - Restricted public API exports in `src/index.ts` | ||
|
|
||
| **Accessibility Improvements:** | ||
|
|
||
| - Fixed RadioGroupField to use proper `role="radiogroup"` with `aria-labelledby` | ||
| - Fixed SwitchField to use proper `role="switch"` with keyboard support (Enter/Space) | ||
|
|
||
| **Bug Fixes:** | ||
|
|
||
| - Fixed `handleSubmit` to mark fields with errors as touched on validation failure | ||
| - Fixed `useAsyncValidation` to properly handle DOMException AbortError | ||
|
|
||
| **Testing:** | ||
|
|
||
| - Added comprehensive test suite with 192 tests | ||
| - Achieved 80%+ coverage: 94.64% statements, 83.77% branches, 83.33% functions | ||
| - Coverage tests for core/, hooks/, and components/ | ||
|
|
||
| **Documentation:** | ||
|
|
||
| - Enhanced JSDoc for FieldType enum values | ||
| - Enhanced JSDoc for ConditionalOperator types |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first line contains a BOM/zero-width character before
---(---). Changesets frontmatter parsing can break when the file doesn't start with a literal---. Remove the BOM so line 1 begins exactly with---.