Add canMapHostMemory and managedMemory skip guards to catch tests#11
Open
Add canMapHostMemory and managedMemory skip guards to catch tests#11
Conversation
Tests using hipHostMalloc, hipMallocManaged, or hipMemPrefetchAsync now check device capabilities and skip with HIP_SKIP_THIS_TEST when the device doesn't support host memory mapping or managed memory. This avoids false failures on backends like clvk with BufferDevAddr. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip tests that require
canMapHostMemoryor managed memory support when the device doesn't advertise these capabilities, instead of failing or crashing.Affected tests:
hipClassKernel,hipHostGetDevicePointer,hipHostMalloc(Default, NonCoherent, CoherentAccess)hipMemcpy,hipMemcpyAsync(H2H-H2D-D2H-H2PinMem variants)hipMemsetFunctional,memset(hostMem)hipMemFaultStackAllocation,hipMemPrefetchAsync_NonPageSz,hipMallocManaged_Basic