Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a download progress window for the I18n mod, providing users with visual feedback during resource pack download and installation operations.
Key changes:
- Introduces a Swing-based GUI window (
LoadDetailUI) that displays download progress, logs, and allows users to cancel operations - Implements stage tracking through the
LoadStageenum to monitor progress through initialization, download, conversion, and application phases - Integrates logging throughout the download workflow to keep users informed
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/i18nupdatemod/core/LoadDetailUI.java | New Swing GUI window for displaying download progress with progress bar, log area, and cancel functionality |
| src/main/java/i18nupdatemod/entity/LoadStage.java | New enum defining five stages of the loading process with descriptions |
| src/main/java/i18nupdatemod/I18nUpdateMod.java | Integrated LoadDetailUI display and shutdown checks at key points in the init workflow |
| src/main/java/i18nupdatemod/core/I18nConfig.java | Added log messages when fetching mirror sources |
| src/main/java/i18nupdatemod/core/ResourcePack.java | Added log messages for download status and completion |
| src/main/java/i18nupdatemod/core/ResourcePackConverter.java | Added log message during resource pack conversion |
| build.gradle.kts | Modified resource processing to handle JSON files separately from mod.json files |
| src/main/resources/icons/CFPA.png | New icon resource for the window |
| src/main/resources/icons/CFPA_with_title.png | New icon resource with title |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AI is so great Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
feat: 出现错误时由手动关闭改为5s后自动关闭 或者5s后自动重试,同时显示停止按钮避免一直循环。 |
自动关闭做好了,个人体感5s略短,改成了6秒。异步重试我想想 |
|
是我的问题吗,拉到本地看了一下并没有出现gui |
|
该 feat 在 1.21.1 neoforge 确认可以生效 |
我怀疑和JDK有关,我本地的Zulu 8的java.awt.headless是true,但是通过设置环境变量强制改为false又能够正常显示GUI。强制修改环境变量会在真的headless的JDK上面抛出异常(虽然我猜能运行MC客户端的JDK应该都不是无头),所以目前是这么放着了。 |
我用的是Zulu JDK 21 |
晚上我看看能不能复现 |
版本 1.21.1 fabric |
已复现,JDK默认为无头状态,修改"java.awt.headless"属性可显示。我比较担心改成纯客户端模组也会有玩家的JDK是真无头。 |
This comment was marked as resolved.
This comment was marked as resolved.
|
还是没有 |
No description provided.