Skip to content

fix(redirector): decode filename before searching in metadata #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sakshamarora1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(redirector): decode filename before searching in metadata #754

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion site/cds_rdm/legacy/redirector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"""Redirector functions and rules."""

from pathlib import Path
from urllib.parse import unquote

from flask import (
Blueprint,
Expand Down Expand Up @@ -69,12 +70,13 @@ def legacy_files_redirect(legacy_id, filename):

# If no version is provided, trickle down the versions and find the newest version that contains the file
if version is None:
filepath = unquote(filename)
all_versions = get_record_versions(record["id"])
for version in sorted(all_versions.keys(), reverse=True):
record_version = all_versions[version]
# Public records with restricted files do not serialize entries
record_version_files = record_version["files"].get("entries", [])
if filename in record_version_files:
if filepath in record_version_files:
record = record_version
break
except PermissionDeniedError:
Expand Down
Loading