Skip to content

Comments

Add standalone script to retrieve HPC cluster name#93

Merged
kelly-sovacool merged 15 commits intomainfrom
issue_92
Jun 9, 2025
Merged

Add standalone script to retrieve HPC cluster name#93
kelly-sovacool merged 15 commits intomainfrom
issue_92

Conversation

@kopardev
Copy link
Contributor

@kopardev kopardev commented Jun 4, 2025

  • feat(hpc): add standalone script to retrieve HPC cluster name
  • fix(hpc): correctly extract resolved module versions from module list output

issues

github-actions bot and others added 6 commits May 30, 2025 15:59
- Extended get_hpcname() to detect helix via hostname when ClusterName is not set
- Added new CLI entry point: `get_hpcname` script in pyproject.toml
- Created new module: src/ccbr_tools/get_hpcname.py to support CLI access
- fix #92
@kopardev kopardev requested a review from kelly-sovacool June 4, 2025 20:55
@kopardev kopardev marked this pull request as ready for review June 4, 2025 20:56
@codecov
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.26%. Comparing base (ea3ba75) to head (195f296).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
src/ccbr_tools/pipeline/hpc.py 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   75.26%   75.26%   -0.01%     
==========================================
  Files          25       25              
  Lines        1779     1787       +8     
==========================================
+ Hits         1339     1345       +6     
- Misses        440      442       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@kelly-sovacool kelly-sovacool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a simple unit test to cover this new feature? See tests/test_pipeline_hpc.py for inspiration.

@kelly-sovacool
Copy link
Member

(p.s. if you do gh pr create without additional arguments, it will give you the option to use the PR template)

@kopardev
Copy link
Contributor Author

kopardev commented Jun 5, 2025

Could you add a simple unit test to cover this new feature? See tests/test_pipeline_hpc.py for inspiration.

Done!

@kopardev
Copy link
Contributor Author

kopardev commented Jun 5, 2025

(p.s. if you do gh pr create without additional arguments, it will give you the option to use the PR template)

Will try to use this next time.

kopardev and others added 3 commits June 5, 2025 18:00
…t` output

Improve `parse_modules` to handle redirected module entries like `snakemake/7 -> snakemake/7.32.4`,
ensuring the resolved version (`7.32.4`) is captured instead of the short name (`7`). This allows
accurate detection of loaded module versions.

Fixes #94
@kopardev
Copy link
Contributor Author

kopardev commented Jun 5, 2025

Now this also fixes #94

@kopardev kopardev changed the title issue 92 issues 92,94 Jun 5, 2025
@kelly-sovacool kelly-sovacool changed the title issues 92,94 Add standalone script to retrieve HPC cluster name Jun 9, 2025
@kelly-sovacool kelly-sovacool merged commit 9308f1c into main Jun 9, 2025
11 checks passed
@kelly-sovacool kelly-sovacool deleted the issue_92 branch June 9, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incomplete version of module listed Create a get_hpcname command to be used in wrapper scripts

2 participants