Skip to content

Remove duplicate namelist variables#692

Merged
SeanBryan51 merged 1 commit intomainfrom
fix-duplicate-namelist-variables
Feb 24, 2026
Merged

Remove duplicate namelist variables#692
SeanBryan51 merged 1 commit intomainfrom
fix-duplicate-namelist-variables

Conversation

@SeanBryan51
Copy link
Collaborator

@SeanBryan51 SeanBryan51 commented Feb 23, 2026

This change removes duplicate module variables for namelist options l_casacnp, l_landuse, l_laiFeedbk, and l_vcmaxFeedbk.

Cherry-picked from #655

Type of change

Please delete options that are not relevant.

  • Bug fix

Checklist

  • The new content is accessible and located in the appropriate section
  • I have checked that links are valid and point to the intended content
  • I have checked my code/text and corrected any misspellings

Testing

  • Are the changes bitwise-compatible with the main branch? If working on an optional feature, are the results bitwise-compatible when this feature is off? If yes, copy benchcab output showing successful completion of the bitwise compatibility tests or equivalent results below this line.
2026-02-24 11:49:25,946 - INFO - benchcab.benchcab.py:380 - Running comparison tasks...
2026-02-24 11:49:25,982 - INFO - benchcab.benchcab.py:381 - tasks: 168 (models: 2, sites: 42, science configurations: 4)
2026-02-24 11:52:24,750 - INFO - benchcab.benchcab.py:391 - 0 failed, 168 passed

Spatial runs are also bitwise compatible:

nccmp -d runs/spatial/tasks/crujra_access_R*_S0/archive/output000/cable_out.nc
nccmp -d runs/spatial/tasks/crujra_access_R*_S1/archive/output000/cable_out.nc
nccmp -d runs/spatial/tasks/crujra_access_R*_S2/archive/output000/cable_out.nc
nccmp -d runs/spatial/tasks/crujra_access_R*_S3/archive/output000/cable_out.nc

📚 Documentation preview 📚: https://cable--692.org.readthedocs.build/en/692/

@SeanBryan51 SeanBryan51 requested review from a team and Whyborn and removed request for a team February 24, 2026 01:27
@Whyborn
Copy link
Contributor

Whyborn commented Feb 24, 2026

Just making sure I understand what was going on- these had definitions in both cable_common and cable_driver_common, which weren't necessarily in sync? There's never any logical reason to have the SAVE attribute on module variables right?

@SeanBryan51
Copy link
Collaborator Author

Just making sure I understand what was going on- these had definitions in both cable_common and cable_driver_common, which weren't necessarily in sync?

Yes

There's never any logical reason to have the SAVE attribute on module variables right?

Nope, pretty sure SAVE is implied for module variables

@Whyborn
Copy link
Contributor

Whyborn commented Feb 24, 2026

Nope, pretty sure SAVE is implied for module variables

Yea, that's what I thought. Confusing stuff.

@SeanBryan51 SeanBryan51 merged commit e887aa2 into main Feb 24, 2026
5 checks passed
@SeanBryan51 SeanBryan51 deleted the fix-duplicate-namelist-variables branch February 24, 2026 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants