Open
Conversation
Collaborator
Author
|
Bitwise comparisons have been tested manually with the following script #!/bin/bash
module load nccmp
set -ex
for f in runs/fluxsite/outputs/*R0*.nc; do
nccmp -d -x Area ${f/R0/R0} ${f/R0/R1}
doneOutput: |
SeanBryan51
requested review from
a team and
ccarouge
and removed request for
a team
2 tasks
SeanBryan51
added a commit
that referenced
this pull request
Feb 27, 2026
There are a few instances where range checks are performed before the variables `met%hod`, `met%doy`, and `met%year` are initialised in the `get_met_data` subroutine. When debug flags are enabled, floating point exceptions are produced when attempting to access these arrays. This occurs for configurations where `MetType /= " "` and `check%ranges /= 0` (i.e. range checks are enabled), and when a variable that is outside the range of its allowed values is detected. I hit this case when writing the `Area` variable in #689. This change makes the `met` arguments optional when range checks are performed during the initialisation phase to avoid the uninitialised access of `met%hod`, `met%doy`, and `met%year`. ## Type of change Please delete options that are not relevant. - [x] Bug fix ## Testing - [x] Are the changes bitwise-compatible with the main branch? If working on an optional feature, are the results bitwise-compatible when this feature is off? If yes, copy benchcab output showing successful completion of the bitwise compatibility tests or equivalent results below this line. ``` 2026-02-27 14:46:49,061 - INFO - benchcab.benchcab.py:380 - Running comparison tasks... 2026-02-27 14:46:49,087 - INFO - benchcab.benchcab.py:381 - tasks: 168 (models: 2, sites: 42, science configurations: 4) 2026-02-27 14:49:32,135 - INFO - benchcab.benchcab.py:391 - 0 failed, 168 passed ``` <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--702.org.readthedocs.build/en/702/ <!-- readthedocs-preview cable end -->
SeanBryan51
force-pushed
the
cable-output-fix-area-variable
branch
from
9c2a9ca to
6aef0ef
Compare
This change writes the Area variable (casamet%areacell) as a parameter instead of a time-varying variable. The Area variable is also only written when CASA is enabled, however it is always defined in the output file. This change additionally fixes the definition of the Area variable such that it is only defined when CASA is enabled.
SeanBryan51
force-pushed
the
cable-output-fix-area-variable
branch
from
6aef0ef to
80bd671
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change writes the Area variable (
casamet%areacell) as a parameter instead of a time-varying variable, ascasamet%areacellis only ever set on initialisation inload_parameters. The Area variable is also only written when CASA is enabled, however it is always defined in the output file. This change additionally fixes the definition of the Area variable such that it is only defined when CASA is enabled.Type of change
Please delete options that are not relevant.
Checklist
Testing
Benchcab comparison tests fail as the Area variable is no longer being defined as CASA-CNP is disabled. Ignoring the Area when running
nccmprestores bitwise compatibility.📚 Documentation preview 📚: https://cable--689.org.readthedocs.build/en/689/