Fix: Ensure SDK global availability for Unity WebGL Decompression Fallback#14
Open
TanguyPinpin wants to merge 1 commit intoByteBrewIO:mainfrom
Open
Fix: Ensure SDK global availability for Unity WebGL Decompression Fallback#14TanguyPinpin wants to merge 1 commit intoByteBrewIO:mainfrom
TanguyPinpin wants to merge 1 commit intoByteBrewIO:mainfrom
Conversation
Changed scope, as it was causing a crash on recent versions of Unity when using Decompression Fallback. When using Decompression Fallback, the loading environment executes .jspre files within a restricted scope, resulting in the SDK becoming inaccessible to .jslib functions. By passing window explicitly into the anonymous factory function we guarantee that the SDK is attached to the browser's global object, making it reachable by the jslib bridge regardless of how the fallback loader executes the script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed scope, as it was causing a crash on recent versions of Unity when using Decompression Fallback.
When using Decompression Fallback, the loading environment executes .jspre files within a restricted scope, resulting in the SDK becoming inaccessible to .jslib functions.
By passing window explicitly into the anonymous factory function we guarantee that the SDK is attached to the browser's global object, making it reachable by the jslib bridge regardless of how the fallback loader executes the script.