[BI-2803] Fix broken preview table on Sub Entity Appends and Observation Variable Stat#461
[BI-2803] Fix broken preview table on Sub Entity Appends and Observation Variable Stat#461jloux-brapi merged 7 commits intodevelopfrom
Conversation
OUIDs will now be filtered by function which filters on dynCols that exist in the associated trait list for a program.
nickpalladino
left a comment
There was a problem hiding this comment.
Testing looked good, couple comments
| if (this.traits.includes(dynCol)) { | ||
| this.phenotypeColumns.push(dynCol); | ||
| } else { | ||
| console.log(`Dynamic column [${dynCol}] not found in the list of available traits for program [${this.activeProgram.name}]`); |
There was a problem hiding this comment.
For logging we have the vuejs-logger available that supports log levels and gives more control of how we manage messages. You can use it like: this.$log.error(msg); It is configured in main.ts and available on all Vue components.
| export default class ImportExperiment extends ProgramsBase { | ||
|
|
||
| async mounted() { | ||
| // Hopefully no more than 100 ontology terms |
There was a problem hiding this comment.
100 is probably reasonable, but we might want to have some sort of indication if there are more than 100 and we're not going to paginate. Could just be a log message.
There was a problem hiding this comment.
I kept the funny comment and added a log message.
|
|
||
| this.createObservationIndexMap(); | ||
|
|
||
| return this.phenotypeColumns.length; |
There was a problem hiding this comment.
Is there a reason this was added, doesn't look like it is used
There was a problem hiding this comment.
It was from some testing I was doing, removed.
Description
Story: BI-2803
Please include a summary of the change that was made.
ImportExperiment:
ImportTemplate:
Dependencies
bi-api PR
Testing
Prerequisites
To test, you will want to try creating a program from scratch, and complete a germplasm and ontology upload. You will need to reference the ontology terms you created as "observation variables" during the testing.
Tests
Verify that on Experiment Import creation workflow, the table preview correctly displays in multiple use cases:
Verify that on Experiment Import appends workflow on a top level dataset, the table preview correctly displays in multiple use cases:
Verify that on Experiment Import appends workflow on a sub entity level dataset, the table preview correctly displays in multiple use cases:
Verify Observation Variable count is correct in the preview in multiple use cases in the Experiment Import Creation workflow:
*Verify Observation Variable count is correct in the preview in multiple use cases in the Experiment Import Appends workflow, for both top-level and sub-entity dataset appends:
Checklist: