Refactor: extract duplicated JSON parsing helpers from DisplayManager#799
Open
blade-running-man wants to merge 1 commit intoBlueforcer:mainfrom
Open
Refactor: extract duplicated JSON parsing helpers from DisplayManager#799blade-running-man wants to merge 1 commit intoBlueforcer:mainfrom
blade-running-man wants to merge 1 commit intoBlueforcer:mainfrom
Conversation
Extract 4 helper functions into Functions.h/.cpp to eliminate repeated JSON parsing blocks in generateCustomPage, generateNotification, and setNewSettings: - getColorField: color parsing with default value - parseGradient: two-color gradient parsing - parseBarLineData: bar/line chart data with autoscale - parseCRGB: CRGB color from hex string or RGB array
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract 4 helper functions into
Functions.h/.cppto eliminate duplicated JSON parsing blocks acrossDisplayManager.cpp.Helpers added
getColorField()parseGradient()parseBarLineData()parseCRGB()Impact
DisplayManager.cppWhy
The same JSON parsing blocks were copy-pasted between
generateCustomPage(),generateNotification(), andsetNewSettings(). A bug fix or format change (e.g. adding HSL support) would require updating 2-7 identical blocks instead of one.