halfagg: Remove fixed limit#16
Open
real-or-random wants to merge 1 commit intoBlockstreamResearch:masterfrom
Open
halfagg: Remove fixed limit#16real-or-random wants to merge 1 commit intoBlockstreamResearch:masterfrom
real-or-random wants to merge 1 commit intoBlockstreamResearch:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one way to deal with the limit. My thinking is that we shouldn't be responsible for the limit.
The drawback of this approach is that it removes some tests. The rust spec is still correct in the sense that you can't possibly have two
Seqs whose combined size is larger thanusize::MAXbecause you won't have enough memory. But that's rather implicit, and it may not be true for implementations using other data types, or in other languages etc. Implementations that want to enforce a limit will have to figure out how to do it, because the spec won't help them.