Draft
Conversation
Contributor
jason-raitz
commented
Feb 13, 2026
jason-raitz
commented
- co-authored with @danschmidt5189
- some logs were still not getting request_id logged
- we believe there an issue with when the two around_performs were called
- this commit should eliminate that problem
- co-authored with @danschmidt5189 - some logs were still not getting request_id logged - we believe there an issue with when the two around_performs were called - this commit should eliminate that problem
jason-raitz
requested review from
anarchivist,
awilfox,
danschmidt5189 and
davezuckerman
Member
danschmidt5189
left a comment
danschmidt5189
left a comment
There was a problem hiding this comment.
Curious about the test failures.
| around_perform :log_job_metadata | ||
| def request_id | ||
| if !defined? @request_id | ||
| if arguments.last.is_a?(Hash) && arguments.last.key?(:request_id) |
Member
There was a problem hiding this comment.
Since it came up on our call, I'll just note you could use find to make this more robust to argument order:
@request_id = args.select { |arg| arg.is_a? Hash }
.find(-> {{}}) { |arg| arg.key?(:request_id) }
.fetch(:request_id)I'm sure there's a more syntactically sugary way to write that, too, but you get the gist. (And yes, it's inefficient to select -> find, I've just done that for clarity.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.