Open
Conversation
* Display button on `UnauthorizedError` instead of redirecting to login. * Use `ForbiddenError` instead of redirecting to login when a user that is not an admin tries to access an admin page in the section for ref cards/stack passes. * Update specs.
Member
Author
Contributor
davezuckerman
left a comment
There was a problem hiding this comment.
Looks good to me as far as the code goes. As for the questions.
I think the current button looks fine (maybe a bit boring) but I don't have a great artistic eye for that kind of stuff.
For the question about a user being logged in but not being an admin. It seems correct to raise the forbidden error. Even if it's a shared computer they should still be logging in as themself right?
yzhoubk
reviewed
Feb 13, 2026
Contributor
yzhoubk
left a comment
There was a problem hiding this comment.
It looks good on my local and the workflow makes sense. Admin page looks solid, would be nice to get Jesse's thoughts too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Display button on
UnauthorizedErrorinstead of redirecting to login.Use
ForbiddenErrorinstead of redirecting to login when a user that is not an admin tries to access an admin page in the section for ref cards/stack passes.Update specs.
Potential TODOs: