Standardize test block syntax for consistency with existing patterns#19
Closed
Standardize test block syntax for consistency with existing patterns#19
Conversation
added struct file for affiliate borrow request moved struct into model for borrow_request removed borrow_request.rb struct file Changing doemoff_patron_email_form to use struct similar to affiliate_borrower Changing stack pass for to use deliver_later Changed deliver_now to deliver_later for more forms Update request_mailer to work with update to efees which uses deliver_later now removed ActiveJob::Base.queue_adapter = :test from affiliate_borrow_request_form, already a default
Co-authored-by: davezuckerman <17831993+davezuckerman@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. |
Copilot
AI
changed the title
[WIP] Update forms to use deliver_later instead of deliver_now
Standardize test block syntax for consistency with existing patterns
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two spec files used multi-line
expect do...endblocks while the codebase standard (established inAffiliateBorrowRequestFormSpec) uses inlineexpect { }syntax.Changes
spec/models/doemoff_patron_email_form_spec.rb: Convertedexpect do...endtoexpect { }spec/models/efees_invoice_spec.rb: Convertedexpect do...endtoexpect { }Example
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.