Skip to content

hotfix: 대성버스 시간표 수정 (develop)#2198

Merged
dh2906 merged 6 commits intodevelopfrom
hotfix/2196-express-bus-timetable
Mar 24, 2026
Merged

hotfix: 대성버스 시간표 수정 (develop)#2198
dh2906 merged 6 commits intodevelopfrom
hotfix/2196-express-bus-timetable

Conversation

@dh2906
Copy link
Contributor

@dh2906 dh2906 commented Mar 24, 2026

🔍 개요


🚀 주요 변경 내용


💬 참고 사항


✅ Checklist (완료 조건)

  • 코드 스타일 가이드 준수
  • 테스트 코드 포함됨
  • Reviewers / Assignees / Labels 지정 완료
  • 보안 및 민감 정보 검증 (API 키, 환경 변수, 개인정보 등)

Summary by CodeRabbit

  • Chores
    • Express bus schedules between Koreatech and the terminal have been updated: several departure/arrival time slots were removed, some adjusted, and new time slots added on both Koreatech→Terminal and Terminal→Koreatech routes. Please review the updated timetable before planning your trip.

kih1015 and others added 4 commits March 3, 2026 20:04
hotfix: 레거시 GET /bus 호환을 위해 주말 direction 기본값을 등교로 처리
release: 2026.03.17 배포
…-fix

hotfix: 키워드 알림 이력 저장 트랜잭션 분리
@dh2906 dh2906 requested a review from Copilot March 24, 2026 05:26
@dh2906 dh2906 self-assigned this Mar 24, 2026
@dh2906 dh2906 added the 버그 정상적으로 동작하지 않는 문제상황입니다. label Mar 24, 2026
@github-actions github-actions bot added the Team Campus 캠퍼스 팀에서 작업할 이슈입니다 label Mar 24, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 03b1bb8a-7cc2-442f-becb-33bc0aa28148

📥 Commits

Reviewing files that changed from the base of the PR and between b4965bc and 2191624.

📒 Files selected for processing (1)
  • src/main/java/in/koreatech/koin/domain/bus/service/express/client/StaticExpressBusClient.java
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/main/java/in/koreatech/koin/domain/bus/service/express/client/StaticExpressBusClient.java

📝 Walkthrough

Walkthrough

Static express bus schedules were updated in the client: specific departure/arrival time blocks were removed, added, or adjusted for both Koreatech→Terminal and Terminal→Koreatech routes without changing APIs or class signatures.

Changes

Cohort / File(s) Summary
Bus Schedule Data Update
src/main/java/in/koreatech/koin/domain/bus/service/express/client/StaticExpressBusClient.java
Koreatech→Terminal: removed 11:05–11:25, 15:05–15:25, 18:55–19:15, 21:05–21:25; added 18:35–18:55, 20:35–20:55. Terminal→Koreatech: added 11:00–11:33; removed 12:30–13:03 and 16:40–17:13; replaced 19:30–20:03 with 19:00–19:33. No signature or API changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through timetables late at night,
Shifted a few minutes left and right,
Removed old hops, planted fresh lore,
Schedules leaner than before —
Buses bound, the campus bright.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the change as a hotfix for the Daesung bus timetable, which directly relates to the code modifications updating schedule data in StaticExpressBusClient.
Linked Issues check ✅ Passed The pull request updates timetable data in StaticExpressBusClient to address the bus schedule mismatch issue [#2196], which matches the linked issue's objective to resolve Daesung Express bus timetable discrepancies.
Out of Scope Changes check ✅ Passed All changes are limited to updating static schedule data in StaticExpressBusClient for Daesung Express bus times, which is directly within the scope of the linked issue #2196.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hotfix/2196-express-bus-timetable

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the static express bus timetable data used by the StaticExpressBusClient to resolve a reported mismatch (close #2196) for the “대성버스” schedule in the express bus domain.

Changes:

  • Removed outdated Koreatech→Terminal departures (e.g., 11:05, 15:05, 18:55, 21:05) and adjusted evening schedule.
  • Added/adjusted Koreatech→Terminal evening departures to 18:35 and 20:35.
  • Added/adjusted Terminal→Koreatech departures (added 11:00, removed 12:30, shifted 16:40 to 17:00).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Mar 24, 2026

Unit Test Results

691 tests   688 ✔️  1m 23s ⏱️
169 suites      3 💤
169 files        0

Results for commit 201a29b.

♻️ This comment has been updated with latest results.

@dh2906 dh2906 merged commit 33ec82c into develop Mar 24, 2026
10 checks passed
@dh2906 dh2906 deleted the hotfix/2196-express-bus-timetable branch March 24, 2026 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team Campus 캠퍼스 팀에서 작업할 이슈입니다 버그 정상적으로 동작하지 않는 문제상황입니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[캠퍼스] 대성 버스 시간표 불일치 해결

5 participants