o2sim: fix time aggregation in dpl-eventgen#15091
Merged
jackal1-66 merged 2 commits intoAliceO2Group:devfrom Feb 23, 2026
Merged
o2sim: fix time aggregation in dpl-eventgen#15091jackal1-66 merged 2 commits intoAliceO2Group:devfrom
jackal1-66 merged 2 commits intoAliceO2Group:devfrom
Conversation
* precalculate batch size so it does not depend on the event counter updated in the generator loop * use DataAllocator::make instead of snapshot to reduce memory churn
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
sawenzel
approved these changes
Feb 23, 2026
sawenzel
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The condition in the loop
depended on the
eventCounterthat was updated inside the loop, thus the batch size was exponentially decreasing, leading to inconsistently sized timeframes being generated.In addition,
pc.outputs().makeis now used to create MCTRACKS and MCHEADER messages, to avoid extra copies done bypc.outputs().snapshot.@jackal1-66 @sawenzel