Skip to content

Comments

feat(frontend): Observability Drawer View Improvements#3783

Open
bekossy wants to merge 5 commits intomainfrom
enhancement-/-observability-drawer-view-improvements
Open

feat(frontend): Observability Drawer View Improvements#3783
bekossy wants to merge 5 commits intomainfrom
enhancement-/-observability-drawer-view-improvements

Conversation

@bekossy
Copy link
Member

@bekossy bekossy commented Feb 19, 2026

Screenshot 2026-02-19 at 9 06 32 AM

@vercel
Copy link

vercel bot commented Feb 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Ready Ready Preview, Comment Feb 20, 2026 6:11pm

Request Review

@bekossy bekossy requested a review from ardaerzin February 20, 2026 13:00
@bekossy bekossy marked this pull request as ready for review February 20, 2026 13:00
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Feb 20, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 19569c49d7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +607 to +609
hideSingleFieldHeader
showFieldCollapse={false}
showFieldDrillIn={false}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep a drill-in entry point for wrapped root payloads

In AccordionTreePanel's drill-in branch, DrillInContent is fed a single synthetic root item (getRootItemsForValue) and then mounted with hideSingleFieldHeader, hideBreadcrumb, and showFieldDrillIn={false}. In this combination, the only root row has no visible header and no drill-in action, so users cannot navigate into nested object/array fields at all when useDrillInView is enabled, which breaks the expected drill-in behavior for trace payloads.

Useful? React with 👍 / 👎.

Comment on lines +304 to +307
if (previousModeRef.current === null) {
if (isMarkdownView) {
editor.dispatchCommand(TOGGLE_MARKDOWN_VIEW, undefined)
}}
tooltipProps={{
title: !markdownView ? "Preview text" : "Preview markdown",
}}
{...props}
/>
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reconcile markdown mode against persisted editor state on mount

MarkdownModeSync skips dispatch when mounting with isMarkdownView === false, so it never corrects an already-persisted markdown state for the same editor id. Because markdown mode is stored via markdownViewAtom storage, switching from Markdown to a non-text mode (which unmounts TextModeViewer) and then back to Text can leave the editor still rendered in markdown while the dropdown says Text.

Useful? React with 👍 / 👎.

…llInView

- Add "Raw" view mode to display original string values before auto-parsing
- Rename "Rendered JSON" to "Field Rendering" for clarity
- Preserve `originalStringValue` in PathItem for stringified JSON fields
- Refactor view mode options logic to show appropriate modes based on data type
- Remove text truncation from ReadOnlyTextView (now handled by editor config)
- Consolidate field rendering logic and improve messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants