Rock - Nyckolle L.#52

Open

NLucuab wants to merge 28 commits intoAda-C15:masterfrom

NLucuab commented May 13, 2021

No description provided.

NLucuab added 28 commits

May 6, 2021 10:50


          completes initial setup

91fd8d2


          updates task.py

a61ec77


          runs migrations

e71bdca


          initializes blueprint registers it in __init__.py

3f8ff6c


          changes to routes & task class

7eadf3c


          adds Procfile file for heroku deployment

8938edf


          changes " to ' in __init__ file & adds comment

b963379


          refactors GET & POST methods

ab16820


          adds is_complete function & improves "POST" method

4e07c82


          refactors to_json funciton & moves "GET" logic

aa9d174


          sets up route for task_id & creates "GET"

14c6110


          adds DELETE logic & adds function comments

3e89ff4


          adds PUT logic & completes Wave 1

c9cbd2f


          adds sort logic for ascending (by title)

32c1dbd


          adds sort logic for descending (by title)

e07e578


          sets up "mark complete" logic for PATCH call

a1852c2


          adds mark_complete endpoint logic

2c3c6f3


          adds "mark incomplete" logic

bd3debe


          adds slack bot function

a0dabbd


          adds column 'title' to goal and runs migrations

99bac13


          sets up goals blueprint

4144db2


          adds goal routes for POST & GET calls

b1a06c4


          adds logic for Goal DELETE & PUT calls

e37df34


          sets up one-to-many relationship btw Goal & Task

0f42ef8


          POST logic for "/<goal_id>/tasks" endpoint

eb303bd


          adds GET logic for one-to-many relationship

bba404f


          adds conditional for to_json Task function

abad9e9


          fixes typo that was causing mapper error

67bf815

spitsfire reviewed

View reviewed changes

spitsfire left a comment

Heck yeah! Good job, Nyckolle! A couple things you could consider for future projects:

For most of the request methods, you separated them out and gave them their own route decorator and function! Awesome. Think about doing that for the GET and POST methods, too. A function should do one thing and one thing only in practice.
Try and make your return statements consistent. Everything can be returned using jsonify(), a dictionary, or make_response(). Any of these options work, some return "extra" headers and data we may/may not need, but it's good to pick just one. That way your endpoints will have consistency when making tests or being read by others!

app/models/goal.py

+                  title = db.Column(db.String)
+                  tasks = db.relationship('Task', backref='goaltask', lazy=True)
+                  def goal_json(self):

spitsfire May 24, 2021

👍 love to see some helper methods!

app/models/task.py

+                  goaltask_id = db.Column(db.Integer, db.ForeignKey('goal.goal_id'), nullable=True)
+                  # creates a dictionary of key-value pairs describing the given task
+                  def to_json(self):

spitsfire May 24, 2021

👍

app/routes.py

@@ @@ -1,2 +1,328 @@ @@
-              from flask import Blueprint
+              from flask import Blueprint, request, jsonify
+              from werkzeug.wrappers import PlainRequest

spitsfire May 24, 2021

since we aren't using this anywhere, we can get rid of it

Suggested change

from werkzeug.wrappers import PlainRequest

app/routes.py

+              from flask import Blueprint, request, jsonify
+              from werkzeug.wrappers import PlainRequest
+              from app import db
+              from flask.helpers import make_response

spitsfire May 24, 2021

we can directly import this from flask above

Suggested change

from flask.helpers import make_response

app/routes.py

		@@ -1,2 +1,328 @@
		from flask import Blueprint
		from flask import Blueprint, request, jsonify

spitsfire May 24, 2021

Suggested change

      
            from flask import Blueprint, request, jsonify
          
            from flask import Blueprint, request, jsonify, makes_response

app/routes.py

Comment on lines +234 to +237

+                  goal = Goal.query.get(goal_id)
+                  if goal is None:
+                      return make_response("", 404)

spitsfire May 24, 2021

here we could use get_or_404(), too!

app/routes.py

+              @goals_bp.route("/<goal_id>", methods=["PUT"], strict_slashes=False)
+              def update_goal(goal_id):
+                  goal = Goal.query.get(goal_id)

spitsfire May 24, 2021

here we could use get_or_404(), too!

app/routes.py

Comment on lines +264 to +267

+                  goal = Goal.query.get(goal_id)
+                  if goal is None:
+                      return make_response("", 404)

spitsfire May 24, 2021

here we could use get_or_404(), too!

app/routes.py

Comment on lines +282 to +286

+                  goal = Goal.query.get(goal_id)
+                  # if no goal with the provided goal_id, returns a 404 error
+                  if not goal:
+                      return make_response("", 404)

spitsfire May 24, 2021

here we could use get_or_404(), too!

app/routes.py

Comment on lines +305 to +311

+                  goal = Goal.query.get(goal_id)
+                  # sets task variable equal to the task with the corresponding goal (in foreignkey column)
+                  task = Task.query.get(goal_id)
+                  # if goal doesn't exist, return a 404 error
+                  if not goal:
+                      return make_response("", 404)

spitsfire May 24, 2021

here we could use get_or_404(), too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet