Reduce size of block_size_descriptor for decompressor builds#587
Merged
solidpixel merged 3 commits intomainfrom Mar 25, 2026
Merged
Reduce size of block_size_descriptor for decompressor builds#587solidpixel merged 3 commits intomainfrom
solidpixel merged 3 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reduces memory footprint for decompressor-only builds by conditionally excluding compressor-only fields from internal data structures guarded by ASTCENC_DECOMPRESS_ONLY, aligning with the goal in #586.
Changes:
- Prune compressor-only members from
decimation_infoandblock_size_descriptorwhenASTCENC_DECOMPRESS_ONLYis defined. - Guard initialization/population code paths in block-size/partition table generation so they compile without the pruned members.
- Minor housekeeping updates (copyright year bumps).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Source/astcenc_partition_tables.cpp | Avoid writing coverage-bitmaps in decompress-only builds; suppress an unused parameter. |
| Source/astcenc_internal.h | Compile-time removal of compressor-only fields from decimation_info and block_size_descriptor in decompress-only builds. |
| Source/astcenc_block_sizes.cpp | Guard initialization of pruned decimation_info fields and k-means texel selection for decompress-only builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces the size of the
block_size_descriptorstructure for compiled decompressor builds which exclude support for compression, significantly reducing memory footprint.After pruning unnecessary fields out of the data structures:
Partial fix for #586