Skip to content

Bump libpng to 1.6.55#3074

Merged
wantehchang merged 1 commit intoAOMediaCodec:mainfrom
vrabaud:main
Mar 3, 2026
Merged

Bump libpng to 1.6.55#3074
wantehchang merged 1 commit intoAOMediaCodec:mainfrom
vrabaud:main

Conversation

@vrabaud
Copy link
Contributor

@vrabaud vrabaud commented Mar 2, 2026 •
edited
Loading

Bump libpng to 1.6.55

@vrabaud vrabaud force-pushed the main branch 2 times, most recently from ebe5110 to 147f952 Compare March 2, 2026 09:43
@vrabaud vrabaud added this to the v1.4.0 milestone Mar 2, 2026
maryla-uc
maryla-uc approved these changes Mar 2, 2026
View reviewed changes
@vrabaud vrabaud force-pushed the main branch 3 times, most recently from 40e2cd9 to 84578c0 Compare March 2, 2026 17:07
@vrabaud vrabaud changed the title Bump libpng and zlib Bump libpng Mar 2, 2026
@vrabaud vrabaud changed the title Bump libpng Bump libpng to 1.6.55 Mar 2, 2026
@vrabaud vrabaud force-pushed the main branch 5 times, most recently from 9949c69 to c9ff014 Compare March 3, 2026 00:04
@wantehchang
Copy link
Collaborator

wantehchang commented Mar 3, 2026

Vincent: Please see my test PR #3081.

The second commit in PR #3081 patches v1.6.55 to behave like v1.6.52. libavif will build successfully and the tests pass, but the combined static library test will fail because libpng static library is built with the .a file extension.

The third commit in PR #3081 works.

Obviously PR #3081 is not ready for check-in. But it shows the assembler program is related to the build failures.

@vrabaud vrabaud force-pushed the main branch 14 times, most recently from 7d942a2 to f738922 Compare March 3, 2026 16:36
@vrabaud
Copy link
Contributor Author

vrabaud commented Mar 3, 2026

@wantehchang , the bug was actually due to pnggroup/libpng@ff615fd

Enabling ASM on MSVC while it does not support it, creates some weird mix of Unix linked flags. What is actually missing is NASM (as recommended by SVT-AV1) when SVT-AV1 is built locally. I am trying one last hack and we can then split this PR.

@vrabaud vrabaud force-pushed the main branch 5 times, most recently from 5b05126 to a838e4c Compare March 3, 2026 22:27
@vrabaud vrabaud marked this pull request as ready for review March 3, 2026 22:27
@vrabaud vrabaud requested a review from wantehchang March 3, 2026 22:27
wantehchang
wantehchang approved these changes Mar 3, 2026
View reviewed changes
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vrabaud
Copy link
Contributor Author

vrabaud commented Mar 3, 2026

Just updated the commit description

@wantehchang wantehchang merged commit 0dbf30d into AOMediaCodec:main Mar 3, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wantehchang wantehchang wantehchang approved these changes

@maryla-uc maryla-uc maryla-uc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@vrabaud @wantehchang @maryla-uc