Try to use SLURM_STEP_GPUS for device list if CUDA_VISIBLE_DEVICES is not set#3577
Open
gabeweisz wants to merge 1 commit intoAI-Hypercomputer:mainfrom
Open
Try to use SLURM_STEP_GPUS for device list if CUDA_VISIBLE_DEVICES is not set#3577gabeweisz wants to merge 1 commit intoAI-Hypercomputer:mainfrom
gabeweisz wants to merge 1 commit intoAI-Hypercomputer:mainfrom
Conversation
gabeweisz
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
aireenmei,
bvandermoon,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jesselu-google,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
suexu1025 and
vipannalla
as code owners
Collaborator
Author
|
@shralex - you asked me to look at this issue - please review the PR |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
gabeweisz
force-pushed
the
gw_check_slurm_gpus
branch
2 times, most recently
from
6f005ab to
7a1f19c
Compare
gabeweisz
force-pushed
the
gw_check_slurm_gpus
branch
from
7a1f19c to
f1c56c3
Compare
Collaborator
Author
|
Tests have all passed, now it is really ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
Description
This makes it easier to use MaxText with GPUs from Slurm since SLURM_STEP_GPUS is set automatically.
Fixes #3433
Tests
Manually tested the change, SLURM_STEP_GPUS set by slurm, with CUDA_VISIBLE_DEVICES and SLURM_STEP_GPUS both set, and with nothing set
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.