Standardize SFT-Tunix integration and add manual step timing#3576
Draft
igorts-git wants to merge 1 commit intomainfrom
Draft
Standardize SFT-Tunix integration and add manual step timing#3576igorts-git wants to merge 1 commit intomainfrom
igorts-git wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the SFT integration with the Tunix library. This change is specifically required to support models with complex sharding rules (like Gemma2) and to fix a universal crash in the metric reporting path.
Key Changes
Why this is needed
Tests
Note: This PR assumes the corresponding change in the Tunix library (adding the skip_sharding_optimizer flag) is present in the environment.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.