Using synthetic dataset_type to optimize test speed for CI workflow#3551
Open
charlesli640 wants to merge 1 commit intoAI-Hypercomputer:mainfrom
Open
Using synthetic dataset_type to optimize test speed for CI workflow#3551charlesli640 wants to merge 1 commit intoAI-Hypercomputer:mainfrom
charlesli640 wants to merge 1 commit intoAI-Hypercomputer:mainfrom
Conversation
charlesli640
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
aireenmei,
bvandermoon,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jesselu-google,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
suexu1025 and
vipannalla
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
charlesli640
force-pushed
the
charlesli/synthetic_dataset
branch
from
4e46f5e to
78ebefe
Compare
gobbleturk
approved these changes
Apr 2, 2026
charlesli640
force-pushed
the
charlesli/synthetic_dataset
branch
2 times, most recently
from
5139de4 to
3fd9852
Compare
bvandermoon
reviewed
Apr 2, 2026
Collaborator
bvandermoon
left a comment
bvandermoon
left a comment
There was a problem hiding this comment.
Thank you @charlesli640. Generally LGTM. We still have other tests covering dataset loading, right?
charlesli640
force-pushed
the
charlesli/synthetic_dataset
branch
from
3fd9852 to
07dbd4e
Compare
charlesli640
force-pushed
the
charlesli/synthetic_dataset
branch
from
07dbd4e to
7985492
Compare
Collaborator
Author
Yes, dataset loading has dedicated test cases. The PR only changes train_test to use synthetic dataset when focus is not on dataset. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Using synthetic dataset_type to optimize train test speed for CI workflow
Tests
CI workflow
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.