Fix math_verify_func for multithreaded environment#3549
Open
SurbhiJainUSC wants to merge 1 commit intomainfrom
Open
Fix math_verify_func for multithreaded environment#3549SurbhiJainUSC wants to merge 1 commit intomainfrom
SurbhiJainUSC wants to merge 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
ee4623e to
ffc18a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The existing
math_verify_func()would fail during training because the underlying Math-Verify 'parse' function usessignal.alarm(), which is incompatible with threaded environments. This results in zero reward score even when the gold and predictions are same.Error:
This PR implements a manual math verification function with a timeout (default=5, same as parse() in math_verify), ensuring it can run safely in a multithreaded context.
Tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.