Change bias initialization from 'embed' to 'heads'#371
Open
Change bias initialization from 'embed' to 'heads'#371
Conversation
Fix the bias sharding axis, it should be output axis instead of input one.
Fix in FlaxAttention
Fix for ApproximateGelu and WanFeedForward too
fix gelu bias too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the bias sharding axis, it should be output axis instead of input one.
Results
mainfixbiasshardingNotes
tp=1configs — improvement only surfaces when tensor parallelism is active, as the axis fixes reduce parameter all-gather overhead in MLP layerstp=4ortp=8where parameter communication is a larger fraction of step timeVideo Quality Comparison
mainfixbiasshardingPSNR/SSIM (frame-by-frame, 81 frames):