Skip to content

Remove direct react dependency, cleanup unused dependencies, upgrade webpack-cli + sass#152

Open
acusti wants to merge 7 commits into40818419:masterfrom
acusti:dependency-cleanup
Open

Remove direct react dependency, cleanup unused dependencies, upgrade webpack-cli + sass#152
acusti wants to merge 7 commits into40818419:masterfrom
acusti:dependency-cleanup

Conversation

@acusti
Copy link
Copy Markdown

@acusti acusti commented Oct 12, 2021

the direct react and react-dom dependencies cause react and react-dom 16 to be installed when adding react-code-input to a react v17.x application, so i removed the direct react and react-dom dependencies, keeping them only as peer dependencies (fixes #75). storybook still takes care of installing them so that npm start works, and yarn build still works. in addition:

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 12, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.55%. Comparing base (2599c5d) to head (fe4ae2d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files           2        2           
  Lines         145      145           
  Branches       41       41           
=======================================
  Hits          140      140           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines -70 to -71
"react": "^16.3.2",
"react-dom": "^16.3.2"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should still be put into devDependencies to show they are directly used by this package, relying on other packages to install your dependencies isn't as good and when using Yarn PnP won't even work as you must declare explicitly all dependencies you import in your package.

@austinbiggs
Copy link
Copy Markdown

Bump! Is there any chance that this will be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install fails on Node version v12.6.0 package.json misconfigured

3 participants