Conversation
replace old plugin with the new one
|
Do not merge yet. |
|
As I mentioned in the telegram group I made the background opacity configurable only via the init.js file in order to keep ui clean. It's now ready to be reviewed and merged |
|
I ended up adding the slider. With this implementation it only appears when the droplet next to the drop-down menu is pressed so it doesn't take up any space. |
0xAF
left a comment
0xAF
left a comment
There was a problem hiding this comment.
I like the result, but I do not like the changes.
I would like you to stay more closely to the original plugin.
Or just make another plugin and send separate PR.
| /* | ||
| * Plugin: colorify the spectrum analyzer. | ||
| * | ||
| * Plugin: Spectravue Style Spectrum Analyzer (Stable & Uncorrupted) |
There was a problem hiding this comment.
why putting new description to the plugin?
| * | ||
| * Plugin: Spectravue Style Spectrum Analyzer (Stable & Uncorrupted) | ||
| * License: MIT | ||
| * Copyright (c) 2023 Stanislav Lechev [0xAF], LZ2SLL |
|
|
||
| Plugins.colorful_spectrum.init = async function () { | ||
|
|
||
| // Check if utils plugin is loaded |
There was a problem hiding this comment.
why removing the comments everywhere?
|
|
||
| for (let i = 0; i < allSelects.length; i++) { | ||
| let text = allSelects[i].textContent || allSelects[i].innerText; | ||
| if (text.includes('Turbo') && text.includes('Ocean') && text.includes('Eclipse')) { |
There was a problem hiding this comment.
why checking for specific theme names?
| Plugins.utils.wrap_func( | ||
| 'draw', | ||
| function (orig, thisArg, args) { return true; }, | ||
| function (res, thisArg, args) { |
|
Ok. I didn't really touch the code my self. Like at all. So I'll try to redo this trying to stay as close as possible to the original code structure |
2 participants
No description provided.